Skip to content

Conversation

@vbatts
Copy link
Member

@vbatts vbatts commented Apr 12, 2016

No description provided.

@wking
Copy link
Contributor

wking commented Apr 12, 2016

I have a ChangeLog commit (through 6734c7a, #370) here 1 if you want
to put that in before the 0.5.0 commit.

wking and others added 3 commits April 12, 2016 09:59
Through 6734c7a (Merge pull request opencontainers#370 from
vbatts/json_schema_and_examples, 2016-04-11).

The only unlisted changes to master were a brief run with ffjson
(opencontainers#343, opencontainers#351), but that was pulled out due to gccgo issues in opencontainers#363.

Signed-off-by: W. Trevor King <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
@vbatts
Copy link
Member Author

vbatts commented Apr 12, 2016

pulled in your ff6e729 commit

On Tue, Apr 12, 2016 at 1:19 AM, W. Trevor King [email protected]
wrote:

I have a ChangeLog commit (through 6734c7a, #370) here 1 if you want
to put that in before the 0.5.0 commit.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#379 (comment)

@mrunalp
Copy link
Contributor

mrunalp commented Apr 12, 2016

LGTM

@mrunalp
Copy link
Contributor

mrunalp commented Apr 12, 2016

@crosbymichael @vishh PTAL

@vishh
Copy link
Contributor

vishh commented Apr 12, 2016

LGTM

1 similar comment
@crosbymichael
Copy link
Member

LGTM

@crosbymichael
Copy link
Member

@vbatts i'll let you merge and tag

@vbatts vbatts merged commit 3f1c150 into opencontainers:master Apr 12, 2016
@vbatts vbatts deleted the bump_version branch April 12, 2016 18:50
@wking
Copy link
Contributor

wking commented Apr 12, 2016

Looks like this missed bumping the example to 0.6.0-dev [1,2]. Maybe
add a note to project.md?

@vbatts
Copy link
Member Author

vbatts commented Apr 12, 2016

@wking not a strict need.

@wking
Copy link
Contributor

wking commented Apr 12, 2016

On Tue, Apr 12, 2016 at 12:22:46PM -0700, Vincent Batts wrote:

@wking not a strict need.

Then I'd rather use a real version number there instead of the current
-dev. And we'd need to remember to bump when any 0.6.0-specific
content landed in the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants